fix: resolve failing tests and type errors across api and shared packages#52
Open
stooit wants to merge 1 commit into
Open
fix: resolve failing tests and type errors across api and shared packages#52stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
…ield, wire bun-types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests and TypeScript errors across the
apiandsharedpackages. After this changebun testreports 22 pass / 0 fail andbunx tsc --noEmitis clean.Fixes
packages/shared/src/utils/pagination.ts): implemented the previously-stubbedpaginate()— page slicing via(page-1)*size,totalPages = Math.ceil(total/size), returns{ data, page, pageSize, total, totalPages }per the test contract.packages/api/src/middleware/auth.ts): fixed the HTTP-method case-sensitivity bug so public routes (e.g.POST /users) are correctly matched and don't require a token. Wired up types so theprocessglobal resolves.Usertype: aligned the field name onusername(wasuserName) across the shared type and allapisource usages, matching what the tests and route handlers expect.packages/api/src/routes/users.ts): added the missingbadRequestimport that was causing the 400-on-missing-fields path to fail.bun-typessobun:testandprocessresolve undertsc --noEmit.Verification
bun test→ 22 pass, 0 failbunx tsc --noEmit→ cleanConstraints honoured
Assumptions
username, the canonical field name was standardised tousername(thesharedtype previously useduserName).